Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protobuf: Do not require version 3 do support Protobuf 4.23.2 (23.2) #544

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Protobuf: Do not require version 3 do support Protobuf 4.23.2 (23.2) #544

merged 1 commit into from
Jun 12, 2023

Conversation

traversaro
Copy link
Contributor

🎉 New feature

GzProtobuf: Do not require version 3 do support Protobuf 4.23.2 (23.2)

Summary

The motivation is similar to gazebosim/gz-msgs#346 .

Test it

Install protobuf 23.2 and run the tests (I guess the only way to do it easily for now is to use conda-forge, see https://repology.org/project/protobuf/versions .

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@traversaro
Protobuf: Do not require version 3 do support Protobuf 4.23.2 (23.2)
3caddd6 
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@traversaro traversaro requested a review from jennuine as a code owner June 6, 2023 21:28
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jun 6, 2023
@scpeters scpeters mentioned this pull request Jun 12, 2023
Closed
46 tasks
scpeters
scpeters approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI failures are unrelated / flaky

@scpeters scpeters merged commit f65395f into gazebosim:ign-gui6 Jun 12, 2023
scpeters pushed a commit that referenced this pull request Jun 12, 2023
@traversaro @scpeters
Find any major version of Protobuf (#544)
69ac1b6 
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@scpeters scpeters mentioned this pull request Jun 12, 2023
Merged
mjcarroll pushed a commit that referenced this pull request Jun 13, 2023
@traversaro @mjcarroll
Find any major version of Protobuf (#544)
0a62a62 
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
@scpeters scpeters mentioned this pull request Jun 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@jennuine jennuine Awaiting requested review from jennuine jennuine is a code owner

Assignees
No one assigned
Labels
🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@traversaro @scpeters