Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix version number in Changelog #112

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Fix version number in Changelog #112

merged 1 commit into from
Jan 26, 2023

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Jan 25, 2023

Fix typo

@azeey azeey requested review from mxgrey and ahcorde as code owners January 25, 2023 06:50
@github-actions github-actions bot added 🏯 fortress Ignition Fortress 🏰 citadel Ignition Citadel labels Jan 25, 2023
@codecov
Copy link

codecov bot commented Jan 25, 2023 •
edited
Loading

Codecov Report

Merging #112 (5dd252d) into ign-plugin1 (1d5a4c9) will not change coverage.
The diff coverage is n/a.

❗ Current head 5dd252d differs from pull request most recent head 287d9b6. Consider uploading reports for the commit 287d9b6 to get more accurate results

@@             Coverage Diff              @@
##           ign-plugin1     #112   +/-   ##
============================================
  Coverage        99.82%   99.82%           
============================================
  Files               15       15           
  Lines              584      584           
============================================
  Hits               583      583           
  Misses               1        1

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

ahcorde
ahcorde requested changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DCO is failing, do you mind to sign the commit @azeey ?

@azeey
Fix version number in Changelog
287d9b6 
Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>
@ahcorde ahcorde enabled auto-merge (squash) January 26, 2023 22:23
@ahcorde ahcorde merged commit c7c2075 into ign-plugin1 Jan 26, 2023
@ahcorde ahcorde deleted the azeey-patch-1 branch January 26, 2023 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
🏰 citadel Ignition Citadel 🏯 fortress Ignition Fortress
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azeey @ahcorde