Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline functions in plugin_unload.hh #118

Merged
merged 1 commit into from
May 9, 2023

Conversation

shameekganguly
Copy link
Contributor

Prevents ODR violation errors in case we include the header in two different translation units compiled into the same test in future.

@github-actions github-actions bot added 🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic labels May 9, 2023
Signed-off-by: Shameek Ganguly <shameekarcanesphinx@gmail.com>
@codecov
Copy link

codecov bot commented May 9, 2023

Codecov Report

Merging #118 (0cca814) into gz-plugin2 (38d6ad1) will not change coverage.
The diff coverage is n/a.

❗ Current head 0cca814 differs from pull request most recent head fe8d615. Consider uploading reports for the commit fe8d615 to get more accurate results

@@             Coverage Diff             @@
##           gz-plugin2     #118   +/-   ##
===========================================
  Coverage       98.26%   98.26%           
===========================================
  Files              23       23           
  Lines             748      748           
===========================================
  Hits              735      735           
  Misses             13       13           

@azeey azeey merged commit 410de69 into gazebosim:gz-plugin2 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden 🎵 harmonic Gazebo Harmonic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants