Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using Pathname to check for absolute path in ruby script #550

Merged
merged 1 commit into from
Nov 5, 2024

Conversation

sauk2
Copy link
Contributor

@sauk2 sauk2 commented Oct 12, 2024

🦟 Bug fix

Part of gazebosim/gz-tools#7

Summary

As suggested in this comment by @scpeters, porting the fix from gazebosim/gz-plugin#131 for determination of absolute path in ruby script.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Saurabh Kamat <kamatsaurabh01@gmail.com>
@sauk2 sauk2 requested a review from caguero as a code owner October 12, 2024 06:54
@github-actions github-actions bot added the 🏛️ ionic Gazebo Ionic label Oct 12, 2024
@scpeters
Copy link
Member

homebrew build is failing due to osrf/homebrew-simulation#2834

@scpeters
Copy link
Member

I experimented with enabling windows tests in d37b501, but I saw a lot of failed to create subprocess errors, so let's not block on that

@azeey
Copy link
Contributor

azeey commented Nov 5, 2024

The failing tests are due to osrf/homebrew-simulation#2834 and not related to this change.

@azeey azeey merged commit f6b65f0 into gazebosim:gz-transport14 Nov 5, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏛️ ionic Gazebo Ionic
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants