Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CI #22

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Fixed CI #22

merged 1 commit into from
Dec 14, 2023

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Dec 14, 2023

🦟 Bug fix

Summary

Fix CI

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Alejandro Hernández Cordero <ahcorde@gmail.com>
@ahcorde ahcorde self-assigned this Dec 14, 2023
Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2e5ac35) 66.00% compared to head (5d30313) 66.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #22   +/-   ##
=======================================
  Coverage   66.00%   66.00%           
=======================================
  Files          29       29           
  Lines        3124     3124           
=======================================
  Hits         2062     2062           
  Misses       1062     1062           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahcorde ahcorde requested a review from azeey December 14, 2023 12:25
@ahcorde
Copy link
Collaborator Author

ahcorde commented Dec 14, 2023

@azeey for some reason the triage is still not working. Do you need to configure something else? I compared the triage.yml with this other one, and they are the same

@azeey
Copy link
Contributor

azeey commented Dec 14, 2023

@azeey for some reason the triage is still not working. Do you need to configure something else? I compared the triage.yml with this other one, and they are the same

Yes, I forgot to add the TRIAGE_TOKEN secret. It's working now.

@ahcorde ahcorde merged commit f7c02fa into main Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants