Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming Joint::ParentLinkName and Joint::ChildLinkName to Joint::ParentName and Joint::ChildName #979

Closed
azeey opened this issue Apr 14, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@azeey
Copy link
Collaborator

azeey commented Apr 14, 2022

Desired behavior

As of SDFormat 1.8, joints can have frames as parent or child elements, so the functions Joint::ParentLinkName and Joint::ChildLinkName are no longer accurate. My suggestion would be to rename them to Joint::ParentName and Joint::ChildName.

Alternatives considered

They could also be named Joint::ParentFrameName and Joint::ChildFrameName since all parent/child elements are frames, either explicit or implicit. However, I think this is a little more confusing if users are not familiar with the explicit/implicit frame concept.

@azeey azeey added the enhancement New feature or request label Apr 14, 2022
@chapulina chapulina added the help wanted Extra attention is needed label Apr 18, 2022
@scpeters
Copy link
Member

see #1053

@azeey azeey closed this as completed Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants