Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail , IncompatibleClassChange #50

Open
jmvanel opened this issue Aug 19, 2020 · 5 comments
Open

Tests fail , IncompatibleClassChange #50

jmvanel opened this issue Aug 19, 2020 · 5 comments

Comments

@jmvanel
Copy link

jmvanel commented Aug 19, 2020

Tests fail both in latest code and in release 2.8 .

Tests in error: 
  ArchiveFileTest.testGetHeader:77->getCore:111 » IncompatibleClassChange Incons...
  ArchiveFileTest.testIterator:45 » IncompatibleClassChange Inconsistent constan...
  DwcaStreamWriterTest.write:49 » IncompatibleClassChange Inconsistent constant ...
  ArchiveFactoryTest.testCoreRecords:59 » IncompatibleClassChange Inconsistent c...
  ArchiveFactoryTest.testCsv:76 » IncompatibleClassChange Inconsistent constant ...
  ArchiveFactoryTest.testCsvOptionalQuotes:125 » IncompatibleClassChange Inconsi...
  ArchiveFactoryTest.testGnubTab:95 » IncompatibleClassChange Inconsistent const...
  ArchiveFactoryTest.testGnubTabZip:113 » IncompatibleClassChange Inconsistent c...
  ArchiveFactoryTest.testIssue78:243 » IncompatibleClassChange Inconsistent cons...
  ArchiveFactoryTest.testOpenArchive:280 » IncompatibleClassChange Inconsistent ...
  ArchiveFactoryTest.testOpenArchiveForEventCore:502 » IncompatibleClassChange I...
  ArchiveFactoryTest.testOpenArchiveForGenericCore:522 » IncompatibleClassChange
  ArchiveFactoryTest.testOpenSmallArchiveWithEmptyLines:314 » IncompatibleClassChange
  ArchiveFactoryTest.testQuotedHeaders:344 » IncompatibleClassChange Inconsisten...
  ArchiveFactoryTest.testTab:368 » IncompatibleClassChange Inconsistent constant...
  ArchiveFactoryTest.testTab2:392 » IncompatibleClassChange Inconsistent constan...
  ArchiveFactoryTest.testTabEol:427 » IncompatibleClassChange Inconsistent const...
Tests run: 73, Failures: 0, Errors: 17, Skipped: 0
@jmvanel jmvanel changed the title Test fail , IncompatibleClassChange Tests fail , IncompatibleClassChange Aug 19, 2020
@MattBlissett
Copy link
Member

Thanks for the report.

All tests pass in Java 8, which is what the project targets. I can see this failure with Java 14, but upgrading to Java 14 isn't something we're likely to work on, and I don't know how complicated any required changes would be.

@jmvanel
Copy link
Author

jmvanel commented Aug 19, 2020

Actually that was tested with:

java -version
openjdk version "11.0.8" 2020-07-14
OpenJDK Runtime Environment (build 11.0.8+10-post-Ubuntu-0ubuntu118.04.1)
OpenJDK 64-Bit Server VM (build 11.0.8+10-post-Ubuntu-0ubuntu118.04.1, mixed mode, sharing)

The error occurs in https://github.com/gbif/gbif-common , which also has in pom.xml
<jdkLevel>1.8</jdkLevel>

So its'likely that all dependent modules should be upgraded together.

It's not blocking for me, I can use the library .
`

@mdoering
Copy link
Member

surprisingly I get the same if I run maven with java11 and do a clean build with mvn clean compile test

@mdoering
Copy link
Member

mdoering commented Aug 19, 2020

I suspect some included library is compiled with an older java version? gbif-common 0.45 maybe? Ive updated to the latest versions locally, but no difference

@jmvanel
Copy link
Author

jmvanel commented Aug 19, 2020

It's possible that compiling gbif-common with java11 fixes most of the 17 errors .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants