Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor code related to poller #35

Closed
gbolo opened this issue Apr 20, 2019 · 0 comments
Closed

refactor code related to poller #35

gbolo opened this issue Apr 20, 2019 · 0 comments
Assignees
@gbolo
Labels
cleanup release-1.1

Comments

@gbolo
Copy link
Owner

gbolo commented Apr 20, 2019 •
edited
Loading

to simplify our poller related code we should:

  • consolidate common.Poller and poller.PollerConfig (they don't need to be separate structs)
  • remove the http handler handlerAddPoller (which takes in a form body) and use the existing handlerPoller for adding both internal and external pollers.
  • refactor the jquery ajax call to POST a json body instead of a form (since handlerPoller only accepts a json body)
  • clear separation between plain-text password and encrypted password
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbolo gbolo

Labels
cleanup release-1.1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbolo