Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liftOperator #47

Closed
wants to merge 4 commits into from
Closed

Conversation

anthonyjoeseph
Copy link
Contributor

@anthonyjoeseph anthonyjoeseph commented Jan 17, 2021

Closes #39 (allows OperatorFunctions e.g. filter to be used on ObservableEither, ObservableThese, ReaderObservableEither and StateReaderObservableEither)

Version of #42, branched from 0.6.12

[Edit: added ObservableThese]

@anthonyjoeseph anthonyjoeseph changed the title 0.6.12 liftOperator Jan 17, 2021
@anthonyjoeseph anthonyjoeseph mentioned this pull request Jan 17, 2021
@anthonyjoeseph anthonyjoeseph force-pushed the liftOperator branch 2 times, most recently from 0e4a534 to 7ac391e Compare January 17, 2021 19:13
@gcanti gcanti closed this Jan 18, 2021
@gcanti gcanti deleted the branch gcanti:0.6.12 January 18, 2021 07:14
@anthonyjoeseph
Copy link
Contributor Author

Alas! Ok I'll release this as a separate package. Any feedback? If not, no worries

@anthonyjoeseph anthonyjoeseph deleted the liftOperator branch January 18, 2021 14:41
@anthonyjoeseph anthonyjoeseph restored the liftOperator branch January 18, 2021 14:41
@gcanti
Copy link
Owner

gcanti commented Jan 18, 2021

@anthonyjoeseph ah I'm sorry...this PR was closed automatically when I released v0.6.12 I guess.

Any feedback?

I need some time, I'm working on fp-ts v2.10 at the moment, sorry.

@gcanti gcanti reopened this Jan 18, 2021
@anthonyjoeseph
Copy link
Contributor Author

No worries! I'll open a new PR against master. Good luck with fp-ts, I'm a big fan!

@gcanti
Copy link
Owner

gcanti commented Jan 18, 2021

I'll open a new PR against master

ok, feel free to release your own package though

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants