Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated tslint #66

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

albohlabs
Copy link

@albohlabs albohlabs commented Aug 2, 2021

The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3

https://github.com/blakeembrey/tslint-config-standard/blob/6968884cb55070bffc3dacb9e6a147aecb639f84/package.json#L67

To get rid of the deprecated tslint and tslint-config-standard packages we can replace it by eslint-config-standard-with-typescript which is based on the eslint-config-standard and suggested in blakeembrey/tslint-config-standard#61

An ESLint shareable config for TypeScript that is based on eslint-config-standard and has TypeScript specific rules from @typescript-eslint/eslint-plugin.

First step to solve #63

@albohlabs albohlabs mentioned this pull request Aug 2, 2021
@albohlabs albohlabs changed the title replace deprecated tslint WIP: replace deprecated tslint Aug 2, 2021
@albohlabs
Copy link
Author

albohlabs commented Aug 2, 2021

TODO:

  • migrate the tslint rules and not disabling them ✅

The typescript version can not be bumped till we get rid of the
deprecated tslint and tslint-config-standard package.
@albohlabs albohlabs changed the title WIP: replace deprecated tslint replace deprecated tslint Aug 2, 2021
@mlegenhausen
Copy link
Collaborator

The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3

This is just a dev dependency and does not enforce a certain TypeScript version on the fp-ts-rxjs project. If you want to add support rxjs 7 you should be able to update typescript without any problems.

@albohlabs
Copy link
Author

albohlabs commented Aug 2, 2021

Hm, maybe i misunderstand something here…

When i try to update the TS version to match the required version of rxjs npm throws the following error message

$ npm install --save-dev typescript@4.3.5
....
npm ERR! Could not resolve dependency:
npm ERR! peer typescript@"^2.2.0 || ^3.0.0" from tslint-eslint-rules@5.4.0
npm ERR! node_modules/tslint-eslint-rules
npm ERR!   tslint-eslint-rules@"^5.3.1" from tslint-config-standard@8.0.1
npm ERR!   node_modules/tslint-config-standard
npm ERR!     dev tslint-config-standard@"^8.0.1" from the root project

But with rxjs 7 and without TS >=4.2 this project can't be build

$ tsc -p ./tsconfig.build.json && tsc -p ./tsconfig.build-es6.json && npm run import-path-rewrite && ts-node scripts/build
…
Found 58 errors.

@bravely
Copy link

bravely commented Nov 7, 2021

@mlegenhausen After giving it a shot, @albohlabs has the right of it. Far as I can tell this does seem like a hard block to upgrading to rxjs 7.

Copy link

@bravely bravely left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not a contributor or anything, but checking for everything I'd expect to need to, you've got it here.

@wnadurski
Copy link

Hi, thanks for this PR :) Are you able to merge it?

@dilame
Copy link

dilame commented Nov 8, 2022

Hello! I would also like to integrate fp-ts and rxjs, but i am using rxjs@7. So i am voting for merging it:)

@JalilArfaoui
Copy link

I need this too ! Is there any blocker ? This PR seems to be ready for a year now …

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants