-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace deprecated tslint #66
base: master
Are you sure you want to change the base?
Conversation
TODO:
|
The typescript version can not be bumped till we get rid of the deprecated tslint and tslint-config-standard package.
This is just a dev dependency and does not enforce a certain TypeScript version on the |
Hm, maybe i misunderstand something here… When i try to update the TS version to match the required version of rxjs npm throws the following error message
But with rxjs 7 and without TS >=4.2 this project can't be build
|
@mlegenhausen After giving it a shot, @albohlabs has the right of it. Far as I can tell this does seem like a hard block to upgrading to rxjs 7. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a contributor or anything, but checking for everything I'd expect to need to, you've got it here.
Hi, thanks for this PR :) Are you able to merge it? |
Hello! I would also like to integrate fp-ts and rxjs, but i am using rxjs@7. So i am voting for merging it:) |
I need this too ! Is there any blocker ? This PR seems to be ready for a year now … |
The project is currently pinned to rxjs 6 because rxjs 7 requires TS 4.2. The problem is that tslint-config-standard enforces TS 3.3
https://github.com/blakeembrey/tslint-config-standard/blob/6968884cb55070bffc3dacb9e6a147aecb639f84/package.json#L67
To get rid of the deprecated tslint and tslint-config-standard packages we can replace it by eslint-config-standard-with-typescript which is based on the
eslint-config-standard
and suggested in blakeembrey/tslint-config-standard#61First step to solve #63