Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CUETools does not retain existing Tracknumber tag when "write basic tags from CUE data" is disabled #221

Closed
bubmann opened this issue Oct 2, 2022 · 2 comments · Fixed by #234
Closed

CUETools does not retain existing Tracknumber tag when "write basic tags from CUE data" is disabled #221

bubmann opened this issue Oct 2, 2022 · 2 comments · Fixed by #234

Comments

@bubmann
Copy link

bubmann commented Oct 2, 2022 •
edited
Loading

using tracks output. at least it does not in a manner visible by foobar2000 or the windows explorer. every other tag seems to be retained ok

The tracknumber track also is not written if tags are taken from MusicBrainz

experienced with FLACCL
@bubmann bubmann mentioned this issue Nov 30, 2022
Open
@c72578
Copy link
Collaborator

c72578 commented Dec 3, 2022 •
edited
Loading

@bubmann Thanks for your report.
The issue could be reproduced in the following case:
Write basic tags from CUE data: disabled
Copy basic tags: enabled

Advanced_Settings_WriteBasicTagsFromCUEData_disabled_CopyBasicTags_enabled

In this case, also the basic tags TRACKNUMBER and TRACKTOTAL should be copied.
Relevant code:

cuetools.net/CUETools.Processor/CUESheet.cs

Line 2957 in 28b0364

if (_config.copyBasicTags && sourceFileInfo != null)

A fix is currently in preparation.

c72578 added a commit to c72578/cuetools.net that referenced this issue Dec 3, 2022
@c72578
Copy basic tags TRACKNUMBER and TRACKTOTAL
471fed8 
So far, the tags TRACKNUMBER and TRACKTOTAL have not been copied in
this case:
CUETools - Advanced settings - Tagging:
  Write basic tags from CUE data: disabled
  Copy basic tags: enabled

- Copy the basic tags 'Track' and 'Trackcount', if 'CopyBasicTags=1'
- Resolves gchudov#221
@c72578 c72578 mentioned this issue Dec 3, 2022
Merged
@c72578
Copy link
Collaborator

c72578 commented Dec 3, 2022 •
edited
Loading

@bubmann Could you please check the build from here, which includes a fix and copies existing tracknumbers:
#234 (comment)

c72578 added a commit to c72578/cuetools.net that referenced this issue Dec 11, 2022
@c72578
Copy basic tags TRACKNUMBER and TRACKTOTAL
d7f0cdd 
So far, the tags TRACKNUMBER and TRACKTOTAL have not been copied in
this case:
CUETools - Advanced settings - Tagging:
  Write basic tags from CUE data: disabled
  Copy basic tags: enabled

- Copy the basic tags 'Track' and 'TrackCount', if 'CopyBasicTags=1'
- Resolves gchudov#221
@c72578 c72578 closed this as completed in 621cbe0 Dec 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Copy basic tags TRACKNUMBER and TRACKTOTAL c72578/cuetools.net
2 participants
@c72578 @bubmann