Update MAC_SDK from 4.44 to 9.04 #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c72578
force-pushed
the
2023-01-24_Update_MAC_SDK_from_4.44_to_9.04
branch
from
634c866
to
f643529
Compare
|
Looking forward to maybe a test build. ;) |
|
Here is a first test build: |
|
Working fine here. Tested converting a bunch of different lossless files into APE without any issues. Converted files plays fine on foobar2000 |
This is a larger update of MAC_SDK to release 9.04. - Original download location: https://monkeysaudio.com/files/MAC_904_SDK.zip SHA256: 09cfebe79986a9b8249cff9c3fd79663692e8e23139903df541905a2ecf44c6a - Several function return values and arguments are 64-bit now in MAC_SDK 9.04, e.g. in IO.h: int64 GetPosition(); int64 GetSize(); Use type `long` accordingly and remove casts, which are not required anymore. - Update the CUETools specific MACLibDll.cpp and MACLibDll.h based on the upstream modifications to MACDll.cpp and MACDll.h, respectively. - Update ThirdParty_MAC_SDK_CUETools.patch accordingly - CUETools.Codecs.MACLib\AudioEncoder.cs: Remove duplicate "m_settings = settings;" - Resolves gchudov#158
c72578
force-pushed
the
2023-01-24_Update_MAC_SDK_from_4.44_to_9.04
branch
from
f643529
to
2c6eb21
Compare
|
@Barough Thanks for testing the build and providing the feedback. |
c72578
added a commit
to c72578/cuetools.net
that referenced
this pull request
Nov 2, 2023
APE files are not encoded correctly using CUETools.Codecs.MACLib, when CUETools is run under 32-bit. This is a regression since the update of MAC_SDK to 9.04 (gchudov#246). No problem under 64-bit. Affected CUETools versions under 32-bit: v2.2.4, v2.2.3 - MACLibDll.cs, c_APECompress_Finish(): Use `long`, which corresponds to `APE::int64`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a larger update of MAC_SDK to release 9.04.
https://monkeysaudio.com/files/MAC_904_SDK.zip
SHA256:
09cfebe79986a9b8249cff9c3fd79663692e8e23139903df541905a2ecf44c6a
MAC_SDK 9.04, e.g. in IO.h:
int64 GetPosition();int64 GetSize();Use type
longaccordingly and remove casts, which are not requiredanymore.
the upstream modifications to MACDll.cpp and MACDll.h, respectively.
Remove duplicate
m_settings = settings;