Fix decoding flac using ffmpeg.dll plugin #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flac files could not be decoded anymore using ffmpeg.dll since ffmpeg version 5.0 (4.4 and earlier were OK). - Using ffmpeg 4.4 or earlier, the following message appeared in the debug output, when decoding flac files using ffmpeg.dll: `Invalid return value 0 for stream protocol` - Newer versions of ffmpeg dlls like 5.0 to 6.1 did not show this output anymore, whereas CUETools got stuck at: "Analyzing input file..." - The problem occurred in av_read_frame() and the readPacketCallback(), where a value of `len = 0` was returned at the end of flac files. - Only decoding of flac files using ffmpeg.dll was affected. Other file formats like aiff, ape, m4a, tta and wv could be decoded properly. - Return AVERROR_EOF instead of 0 in readPacketCallback() - Resolves gchudov#300
|
Here is a build for testing, which allows decoding flac files again using the ffmpeg.dll plugin: Download links for the required ffmpeg 6.0 dlls can be found e.g. here: @ha-korth, could you please have a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flac files could not be decoded anymore using ffmpeg.dll since ffmpeg
version 5.0 (4.4 and earlier were OK).
debug output, when decoding flac files using ffmpeg.dll:
Invalid return value 0 for stream protocoloutput anymore, whereas CUETools got stuck at:
"Analyzing input file..."
av_read_frame()and thereadPacketCallback(),where a value of
len = 0was returned at the end of flac files.formats like aiff, ape, m4a, tta and wv could be decoded properly.
AVERROR_EOFinstead of0inreadPacketCallback()