-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUERipper: Detect too large album art earlier #311
CUERipper: Detect too large album art earlier #311
Conversation
The maximum size of embedded album art is 16 MB each. So far, an exception was shown after ripping the CD, when tagging the files: "Block size too large." - Show an earlier warning, after downloading too large album art and before starting to rip the CD. - Switch to `Album art size` `Small`, if the album art is larger than 16 MB and `Embed album art` is set. - The following warning is shown: "Selected album art has a size of x bytes, which is too large for embedding (max 16 MB). Small album art will be used instead." - This is a follow-up to commit gchudov/taglib-sharp@8590ad0 Prevent taglib from corrupting flac files when embedded album art exceeds 16Mb
Here is a build for testing: If the selected album art is larger than 16 MB and the option "Embed album art" is set, then the following warning is shown: |
Art size dropped from 39.9 MB to 19.6 KB so works. |
- Use Properties.Resources for the title and message in the new MessageBox "Album art too large". - Show "Downloading album art..." in the status of CUERipper to inform the user, what is going on, because downloading of large album art may take some time. - Add German translations.
@ha-korth Thanks for testing. |
A new test build has been prepared: In addition to showing a message in case of too large album art, "Downloading album art..." is shown in the status of CUERipper while downloading, to show what is going on, as downloading of large album art may take some time. See green arrow: |
Mine shows as |
Yes, this is the reason, why the status message "Downloading album art..." has been added now. hangs for about 5minutes, then starts ripping the disc |
Found another issue with larger album art in CUERipper. Just wanted to make a note of it somewhere. |
The maximum size of embedded album art is 16 MB each.
So far, in case of too large album art, an exception was shown after
ripping the CD, when tagging the files: "Block size too large."
When using libFLAC, an exception appeared at the beginning of ripping
"Exception: unable to initialize the encoder:"
FLAC__STREAM_ENCODER_INIT_STATUS_ENCODER_ERROR
and before starting to rip the CD.
Album art size
Small
, if the album art is larger than16 MB and
Embed album art
is set."Selected album art has a size of x bytes, which is too large for
embedding (max 16 MB). Small album art will be used instead."
Prevent taglib from corrupting flac files when embedded album art
exceeds 16Mb
Properties.Resources
for the title and message in the newMessageBox "Album art too large" to allow translation.
the user, what is going on, because downloading of large album art
may take some time.