From 04de996ff0d4a8844dd13e1a9f8e5753c8b12fcb Mon Sep 17 00:00:00 2001 From: Graham Clark Date: Sat, 4 Jun 2022 23:24:24 -0400 Subject: [PATCH] Fix typo in menu operation leading to UI inconsistencies In the callbacks for the log viewer and config viewer menu selection, I was closing the wrong menu - analysis instead of menu - which had the effect of leaving the original menu open but hidden. However the hidden menu still swallowed keypresses, making operation of the default pager confusing and unpredictable for the config and log files. --- ui/ui.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/ui.go b/ui/ui.go index a57ef0f..187a01a 100644 --- a/ui/ui.go +++ b/ui/ui.go @@ -3390,14 +3390,14 @@ func Build() (*gowid.App, error) { Txt: "Show Log", Key: gowid.MakeKey('l'), CB: func(app gowid.IApp, w gowid.IWidget) { - multiMenu1Opener.CloseMenu(analysisMenu, app) + multiMenu1Opener.CloseMenu(generalMenu, app) openLogsUi(app) }, }) generalMenuItems = append(generalMenuItems, menuutil.SimpleMenuItem{ Txt: "Show Config", CB: func(app gowid.IApp, w gowid.IWidget) { - multiMenu1Opener.CloseMenu(analysisMenu, app) + multiMenu1Opener.CloseMenu(generalMenu, app) openConfigUi(app) }, })