diff --git a/ui/ui.go b/ui/ui.go index 65f264fc..59a08543 100644 --- a/ui/ui.go +++ b/ui/ui.go @@ -1353,11 +1353,6 @@ func lastLineMode(app gowid.IApp) { return nil })) - MiniBuffer.Register("help", minibufferFn(func(gowid.IApp, ...string) error { - OpenTemplatedDialog(appView, "UIHelp", app) - return nil - })) - MiniBuffer.Register("no-theme", minibufferFn(func(app gowid.IApp, s ...string) error { mode := theme.Mode(app.GetColorMode()).String() // more concise termshark.DeleteConf(fmt.Sprintf("main.theme-%s", mode)) diff --git a/widgets/minibuffer/minibuffer.go b/widgets/minibuffer/minibuffer.go index 42d21e50..41663526 100644 --- a/widgets/minibuffer/minibuffer.go +++ b/widgets/minibuffer/minibuffer.go @@ -294,10 +294,14 @@ func (w *Widget) handleSelection(keyIsEnter bool, app gowid.IApp) { extraPrefix += string(c) } longestPrefixPartial := partials[selectedIdx] - // e.g. "cl" + "ear-" from ["clear-packets", "clear-filter"] - longestPrefixPartial.qword = words[len(words)-1] + extraPrefix - w.ed.SetText(longestPrefixPartial.Line(), app) - w.ed.SetCursorPos(longestPrefixPartial.CursorPos(), app) + // if the user types e.g. "help " then hits tab, extraPrefix will be "" (no characters typed + // to start selection of next argument) so don't complete. + if extraPrefix != "" { + // e.g. "cl" + "ear-" from ["clear-packets", "clear-filter"] + longestPrefixPartial.qword = words[len(words)-1] + extraPrefix + w.ed.SetText(longestPrefixPartial.Line(), app) + w.ed.SetCursorPos(longestPrefixPartial.CursorPos(), app) + } } } }