Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recent playoverwatch.com changes #14

Closed
Archomeda opened this issue Dec 18, 2017 · 4 comments
Closed

Recent playoverwatch.com changes #14

Archomeda opened this issue Dec 18, 2017 · 4 comments
Assignees

Comments

@Archomeda
Copy link

The website has been changed a bit recently:

  • There are no more region based statistics; all region based URLs are redirected to the same profile now
  • Searching accounts apparently now supports multiple results, and apparently you can use https://playoverwatch.com/en-us/search/account-by-name/<name> as a JSON endpoint directly

Maybe there are some more changes, but this is all I know of.

@gclem
Copy link
Owner

gclem commented Dec 18, 2017

I'll look at it this week if I get some free time.

@gclem gclem self-assigned this Dec 19, 2017
@gclem
Copy link
Owner

gclem commented Dec 19, 2017

Just checked, and I don't see any troubles. All is working fine.

Could you confirm please

@Archomeda
Copy link
Author

I guess with the changes you made in 7a5c0a9 it fixed the issue of using tags with a dash instead of using the hashtag, since you explicitly replace it now. I didn't check how the search endpoint previously worked, so the rest might have stayed the same.

There's still the case of the removed regions. It currently works as is, but only because of the catch-all https://playoverwatch.com/en-us/career/<platform>/<region>/<battletag> that redirects to https://playoverwatch.com/en-us/career/<platform>/<battletag>. This might get removed later without notice. Regions are no longer used by the website. You might as well remove the region parameter them from the functions entirely, but this is a breaking change.

@gclem
Copy link
Owner

gclem commented Jan 3, 2018

Will be plannned on next version. Thanks for the feedback @Archomeda

@gclem gclem closed this as completed Jan 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants