Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ranking !== Rank #7

Closed
AxeBane opened this issue Jun 18, 2017 · 2 comments
Closed

Ranking !== Rank #7

AxeBane opened this issue Jun 18, 2017 · 2 comments
Assignees
Labels

Comments

@AxeBane
Copy link

AxeBane commented Jun 18, 2017

There's a mismatch between the SR that the API calls and the "rank" that it lists (i.e. Silver, Diamond, Master...)

Examples I can call upon are as follows:

My Account reads 3040 SR but displays the rank as Master, when it should be Diamond.
A friend's account reads 2772 SR, ranks Diamond. Should be Platinum.
A friend's alt ranks 2588 SR, ranks Diamond. Should be Platinum.
A random account I scraped off of BattleNet had an SR of 734, and classed as Gold. THIS IS BRONZE.

Clearly there's some kind of issue with how the API interprets the ranking. It's probably a simple fix.

@gclem
Copy link
Owner

gclem commented Jun 18, 2017

Thanks AxeBane,
Will investigate to fix this.

I'm based on the ranking image, seems has been changed

@gclem gclem added the bug label Jun 18, 2017
@gclem gclem self-assigned this Jun 18, 2017
@gclem gclem closed this as completed in 2cea78b Jun 18, 2017
@gclem
Copy link
Owner

gclem commented Jun 18, 2017

Done

Thx for the feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants