nest exec plugin assertions under assert field
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm aligning all of the plugin assertion fields with a name of `assert`.
This commit changes the first plugin, `exec` to nest the `exit_code`,
`err` and `out` assertion structs under an `assert` field object in the
Spec.
So, instead of this:
```yaml
tests:
- exec: echo cat
out:
is: cat
```
you now do this:
```yaml
tests:
- exec: echo cat
assert:
out:
is: cat
```
I'm changing the `http` plugin's assertions block from `response` to
`assert` and the `kube` plugin's assertions block from `kube.assert` to
just `assert` in followup PRs in those repositories.
Signed-off-by: Jay Pipes <jaypipes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm aligning all of the plugin assertion fields with a name of
assert. This commit changes the first plugin,execto nest theexit_code,errandoutassertion structs under anassertfield object in the Spec.So, instead of this:
you now do this:
I'm changing the
httpplugin's assertions block fromresponsetoassertand thekubeplugin's assertions block fromkube.assertto justassertin followup PRs in those repositories.