-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LP new signal simulation #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add apothem and radius of small silicon cells.
Take into account also half cells in silicon wafers by using the same sensitive detector of full cells. Extend number of cells to 132 for both CEE and CEH.
Include auxiliary class to calculate x and y position of small si cells.
Add functions to calculate MIP signal per layer and tag pion interacting layer in CEE according to CMS publication.
Access PDGID and energy of primary particle using the PrimaryGenAction and save info in root format.
Use SignalHelper class methods to tag interacting pions in CEE and save interaction layer in ROOT output file.
Add version control for overlap check method. Define it only for G4-11.0 and up.
In order to find layer of corresponding nuclear interaction in CEE, pass vector of signals already calibrated at the MIP scale. Use an auxiliary lambda function for in EventAction.
Add printout information for SignalHelper IsInteraction() method.
To identify CEE interaction layer check also if the layer has at least 3 Si cells above threshold.
Apply the same stragy to tag interacting pions in CHE as done in CEE. Simply consider the central Si pad for CHE layers. Save corresponding layer number in ROOT file.
Fix bug when accessing signals per CHE layer in EventAction EndOfEvent method.
Add simplified method for Birk correction. To be used only for comparison with the CMS one.
Add units for Brik1 coefficient as done in CMSSW. It restores a-dimensionality of Birks Law. Remove density convertion to g/cm3 for consistency.
Update value of MIP calibration constants for silicon and tiles.
Discard events interacting in the first two layers of CEE, or not interacing both in CEE and CHE or with interacting layer not found. Use CEEInteracted variable to select CEE and CHE events. Perform gaussian fit to extract response as the pick value of distributions (as written in TB paper) by fitting around maximum of histograms.
Accepting PR #20. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several improvements in signal simulation and event tagging.