Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update GeanyLua for Scintilla 5 #1118

Closed
eht16 opened this issue Oct 10, 2021 · 2 comments · Fixed by #1123
Closed

Update GeanyLua for Scintilla 5 #1118

eht16 opened this issue Oct 10, 2021 · 2 comments · Fixed by #1123

Comments

@eht16
Copy link
Member

eht16 commented Oct 10, 2021

After geany/geany#2867 has been merged, the GeanyLua plugin needs to be updated to work with the new Scintilla version.

Currently, compilation fails as follow:

make: Entering directory '/home/enrico/projects/geany-plugins/geanylua'
Making all in docs
make[1]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/docs'
make[1]: Nothing to be done for 'all'.
make[1]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/docs'
Making all in examples
make[1]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples'
Making all in dialogs
make[2]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples/dialogs'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples/dialogs'
Making all in edit
make[2]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples/edit'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples/edit'
Making all in info
make[2]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples/info'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples/info'
Making all in scripting
make[2]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples/scripting'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples/scripting'
Making all in work
make[2]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples/work'
make[2]: Nothing to be done for 'all'.
make[2]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples/work'
make[2]: Entering directory '/home/enrico/projects/geany-plugins/geanylua/examples'
make[2]: Nothing to be done for 'all-am'.
make[2]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples'
make[1]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua/examples'
make[1]: Entering directory '/home/enrico/projects/geany-plugins/geanylua'
  CC       libgeanylua_la-glspi_sci.lo
  CC       geanylua_la-geanylua.lo
In file included from glspi_sci.c:11:
glspi_sci.h:369:39: error: ‘SCI_GETTWOPHASEDRAW’ undeclared here (not in a function); did you mean ‘SCI_GETPHASESDRAW’?
  369 |         {"GETTWOPHASEDRAW", SLT_BOOL, SCI_GETTWOPHASEDRAW, SLT_VOID, SLT_VOID},
      |                                       ^~~~~~~~~~~~~~~~~~~
      |                                       SCI_GETPHASESDRAW
  CCLD     geanylua.la
glspi_sci.h:370:39: error: ‘SCI_SETTWOPHASEDRAW’ undeclared here (not in a function); did you mean ‘SCI_SETPHASESDRAW’?
  370 |         {"SETTWOPHASEDRAW", SLT_VOID, SCI_SETTWOPHASEDRAW, SLT_BOOL, SLT_VOID},
      |                                       ^~~~~~~~~~~~~~~~~~~
      |                                       SCI_SETPHASESDRAW
glspi_sci.h:711:32: error: ‘SCI_SETLEXER’ undeclared here (not in a function); did you mean ‘SCI_SETILEXER’?
  711 |         {"SETLEXER", SLT_VOID, SCI_SETLEXER, SLT_INT, SLT_VOID},
      |                                ^~~~~~~~~~~~
      |                                SCI_SETILEXER
glspi_sci.h:716:40: error: ‘SCI_SETLEXERLANGUAGE’ undeclared here (not in a function); did you mean ‘SCI_GETLEXERLANGUAGE’?
  716 |         {"SETLEXERLANGUAGE", SLT_VOID, SCI_SETLEXERLANGUAGE, SLT_VOID, SLT_STRING},
      |                                        ^~~~~~~~~~~~~~~~~~~~
      |                                        SCI_GETLEXERLANGUAGE
glspi_sci.h:717:40: error: ‘SCI_LOADLEXERLIBRARY’ undeclared here (not in a function)
  717 |         {"LOADLEXERLIBRARY", SLT_VOID, SCI_LOADLEXERLIBRARY, SLT_VOID, SLT_STRING},
      |                                        ^~~~~~~~~~~~~~~~~~~~
make[1]: *** [Makefile:862: libgeanylua_la-glspi_sci.lo] Error 1
make[1]: *** Waiting for unfinished jobs....
make[1]: Leaving directory '/home/enrico/projects/geany-plugins/geanylua'
make: *** [Makefile:916: all-recursive] Error 1
make: Leaving directory '/home/enrico/projects/geany-plugins/geanylua'
``
@elextr
Copy link
Member

elextr commented Oct 10, 2021

Not surprising really. Scintilla has jumped two major versions, so its API has changed (twice) incompatibly.

@Skif-off
Copy link
Contributor

GeanyLua: Update glspi_sci.h will fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants