Committing files generated by beforeBump task

[gxxcastillo]

beforeBump runs a build script in my library which generates 3 files. However, the 3 files are not being added to my commit. Is this expected behavior?

This is my config:

release: {
            options: {
                file: 'bower.json',
                additionalFiles: ['package.json'],
                beforeBump: ['build'],
                npm: false,
                npmtag: false
            }
}

[gxxcastillo]

hmmm... looks like this was intentional?

    function add(){
      var files = config.files.join(' ');
      grunt.log.ok('files:' + files);
      return run('git add ' + files, ' staged ' + files);
    }

Any reason we wouldn't want to do a git add . --all?

Should there be an addAll config option?

[ritz078]

👍 There no point to change your files before Release or bump if you are not commiting it.

[Klortho]

+1

[bago]

Or maybe alter the "add" command syntax to allow a list of files to be added... it would be even more intuitive. What's the point of the current "add" command? To add to the repository the package-lock or the changelog if they never existed before? How often does it happen?

[blendsdk]

I have a similar case where my build script needs to change some files. These files need to be committed also.