Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: download button on website is broken #41

Closed
tomsquest opened this issue Apr 1, 2024 · 6 comments
Closed

bug: download button on website is broken #41

tomsquest opened this issue Apr 1, 2024 · 6 comments
Labels
bug Something isn't working nice_to_have

Comments

@tomsquest
Copy link

Hi,

On DocKit website, the download button is not working.
I think the error comes from:

TypeError: navigator.userAgentData is undefined
    n https://dockit.geekfun.club/assets/chunks/theme.lK2rZp0k.js:1
    Ge https://dockit.geekfun.club/assets/chunks/framework.PNMSvVW_.js:1
    Se https://dockit.geekfun.club/assets/chunks/framework.PNMSvVW_.js:1
    n https://dockit.geekfun.club/assets/chunks/framework.PNMSvVW_.js:1

image

@Blankll
Copy link
Member

Blankll commented Apr 1, 2024

Hi, @tomsquest may I get your machine arch, os name and os version?

And the browser

@tomsquest
Copy link
Author

Hi @Blankll

Pretty sure it is being blocked by Firefox privacy settings.

I am using 124.0.1 (64-bit) on Ubuntu, ublock, tracking protection in strict mode.

@Blankll
Copy link
Member

Blankll commented Apr 3, 2024

Thanks, I'll have a look, but chrome should be work, I've been tested it

@Blankll Blankll added bug Something isn't working nice_to_have labels Apr 7, 2024
@Blankll
Copy link
Member

Blankll commented Apr 7, 2024

the function to detect host arch and OS is supported only by limited browsers, btw I have added auto-new version detect to directly download the latest version instead of visiting the browser again, this issue should be not necessary to fix then
see the support list: https://developer.mozilla.org/en-US/docs/Web/API/Navigator/userAgentData

@tomsquest
Copy link
Author

Ok.

Suggestion: the Releases section of Github could be fallback if the download code failed to execute.

@Blankll
Copy link
Member

Blankll commented Jul 9, 2024

Hi, the download page has improved with the new UI, user can decide what platform they want to download, and it does not rely on the browser API then, I will close this issue, thanks for the feedback and feel free to raise issues if there any other feature/improvement we want DocKit to have cheers!

Screenshot 2024-07-10 at 01 08 08

@Blankll Blankll closed this as completed Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working nice_to_have
Projects
None yet
Development

No branches or pull requests

2 participants