Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Personal code review on Code Quality #4

Open
geekelo opened this issue Jun 20, 2023 · 0 comments
Open

Personal code review on Code Quality #4

geekelo opened this issue Jun 20, 2023 · 0 comments

Comments

@geekelo
Copy link
Owner

geekelo commented Jun 20, 2023

Aside from the suggested improvement below, the code in all files are DRY, KISS, YAGNI AND FOLLOW HTML, CSS, and JS best practices.

  • In the print.js file, the functions can be broken down into separate modules for readability and maintainability of code
  • Include descriptive but brief comments about what each module works
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant