Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS: guid could not be a link #4

Open
ghost opened this issue Sep 13, 2012 · 1 comment
Open

RSS: guid could not be a link #4

ghost opened this issue Sep 13, 2012 · 1 comment

Comments

@ghost
Copy link

ghost commented Sep 13, 2012

Currently the RSS parser takes the element as the news link. This works correctly most of the times. However, when its "isPermaLink" attribute is set to "false" it might not be a link (e.g. in my diocese's RSS it's a UUID). The RSS 2.0 standards confirm this:

isPermaLink is optional, its default value is true. If its value is false, the guid may not be assumed to be a url, or a url to anything in particular.

I was thinking in taking the link from the element. I didn't want to change this before checking it with you first. Do you see any problems to this change?

Thank you!

@geerlingguy
Copy link
Owner

No, that should be fine. I think I just did that because the feed in question used the guid... but spot-checking a few different RSS feeds out there, it seems <link> is used pretty much universally. Neither is perfect since the implementation of RSS is not perfect everywhere, but it follows the spec (as you stated).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant