Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos in Algorithm 8 (?) and general algo-inconsistencies #3

Open
prisae opened this issue May 2, 2023 · 1 comment
Open

Typos in Algorithm 8 (?) and general algo-inconsistencies #3

prisae opened this issue May 2, 2023 · 1 comment

Comments

@prisae
Copy link

prisae commented May 2, 2023

Hi Geir,

First of all, big thanks to the authors for the work and even more so for making this great resource available open-access, much appreciated!

  1. Potential typos in algorithm 8
    In algorithm 8, it states

    • on lines 4 AND 5 «Loop over assimilation windows». Shouldn't the latter be something along the lines of «Loop over ESMDA steps»?
    • on line 19 Z=X_N. Is that right or should it be Z=X_K (as in algorithm 7)?
  2. Inconsistency
    In algorithms 1-4, for-loops are defined using a colon, for k = 1 : N do. In algorithms 7-11 and 14, however, for-loops are defined using a comma, for k = 1, N do (algorithms 5,6,12,13 have no for-loops).

  3. for l = 1,... do
    In algorithms 7 and 8, there is the line for l = 1,... do. Is that on purpose?

@geirev
Copy link
Owner

geirev commented May 3, 2023

Thanks for spotting these typos!
We will fix them in the next revision of course.
Geir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants