fix: error does not display in report

gemini-testing · Jul 17, 2018 · b471707 · b471707
1 parent 85aa204
commit b471707
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 4 deletions.
diff --git a/lib/static/modules/utils.js b/lib/static/modules/utils.js
@@ -7,11 +7,10 @@ const {getCommonErrors} = require('../../constants/errors');
 const {NO_REF_IMAGE_ERROR} = getCommonErrors();
 
 function hasFailedImages(result) {
-    const {imagesInfo, status} = result;
+    const {imagesInfo = [], status} = result;
 
-    return imagesInfo.length
-        ? imagesInfo.some(({status}) => isErroredStatus(status) || isFailStatus(status))
-        : isErroredStatus(status) || isFailStatus(status);
+    return imagesInfo.some(({status}) => isErroredStatus(status) || isFailStatus(status))
+        || isErroredStatus(status) || isFailStatus(status);
 }
 
 function hasFails(node) {

diff --git a/test/lib/report-builder-factory/report-builder.js b/test/lib/report-builder-factory/report-builder.js
@@ -260,6 +260,28 @@ describe('ReportBuilder', () => {
                 assert.equal(suiteResult.status, SUCCESS);
             });
         });
+
+        describe('should not rewrite suite status to "success" if image comparison is successful, but test', () => {
+            [
+                {status: 'failed', methodName: 'addFail'},
+                {status: 'errored', methodName: 'addError'}
+            ].forEach(({status, methodName}) => {
+                it(`${status}`, () => {
+                    const reportBuilder = mkReportBuilder_();
+
+                    const test = stubTest_({
+                        imagesInfo: [{stateName: 'plain', status: SUCCESS}]
+                    });
+
+                    reportBuilder.addIdle(test);
+                    reportBuilder[methodName](test);
+
+                    const suiteResult = getSuiteResult_(reportBuilder);
+
+                    assert.equal(suiteResult.status, FAIL);
+                });
+            });
+        });
     });
 
     describe('addRetry', () => {