fix: don't show error-details for assertView failures

gemini-testing · Oct 2, 2019 · ef1bac9 · ef1bac9
1 parent e532d83
commit ef1bac9
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/README.md b/README.md
@@ -28,6 +28,7 @@ directory.
 ```
    const err = new Error('some error');
    err.details = {title: 'description, will be used as url title', data: {} | [] | 'some additional info'};
+   throw err;
 ```
 * **defaultView** (optional) `String` - default view mode. Available values are:
   * `all` - show all tests. Default value.

diff --git a/lib/static/components/section/body/index.js b/lib/static/components/section/body/index.js
@@ -131,27 +131,29 @@ class Body extends Component {
 
     _getTabs() {
         const activeResult = this._getActiveResult();
+        const {errorDetails} = activeResult;
         const retryIndex = this.state.retry;
 
         if (isEmpty(activeResult.imagesInfo)) {
-            return isSuccessStatus(activeResult.status) ? null : this._drawTab(activeResult);
+            return isSuccessStatus(activeResult.status) ? null : this._drawTab(activeResult, {errorDetails});
         }
 
         const tabs = activeResult.imagesInfo.map((imageInfo, idx) => {
             const {stateName} = imageInfo;
             const error = imageInfo.error || activeResult.error;
 
-            return this._drawTab(imageInfo, `${stateName || idx}_${retryIndex}`, {image: true, error});
+            const options = imageInfo.stateName ? {} : {errorDetails};
+
+            return this._drawTab(imageInfo, {...options, image: true, error}, `${stateName || idx}_${retryIndex}`);
         });
 
         return this._shouldAddErrorTab(activeResult)
-            ? tabs.concat(this._drawTab(activeResult))
+            ? tabs.concat(this._drawTab(activeResult, {errorDetails}))
             : tabs;
     }
 
-    _drawTab(state, key = '', opts = {}) {
+    _drawTab(state, opts = {}, key = '') {
         const {result: {name: browserId}, suite: {suitePath}} = this.props;
-        const {errorDetails} = this._getActiveResult();
 
         opts = defaults({error: state.error}, opts);
 
@@ -161,7 +163,7 @@ class Body extends Component {
                     <State
                         state={state} suitePath={suitePath} browserId={browserId}
                         acceptHandler={this.onTestAccept} toggleHandler={this.onToggleStateResult}
-                        findSameDiffsHandler={this.onTestFindSameDiffs} {...opts} errorDetails={errorDetails}
+                        findSameDiffsHandler={this.onTestFindSameDiffs} {...opts}
                     />
                 </div>
             </div>