Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Valid Actions don't incur reward due to typo (ChessEnvV1) #22

Open
Japple42 opened this issue Nov 4, 2021 · 3 comments
Open

Valid Actions don't incur reward due to typo (ChessEnvV1) #22

Japple42 opened this issue Nov 4, 2021 · 3 comments

Comments

@Japple42
Copy link

Japple42 commented Nov 4, 2021

line 254, there's a comment that says "valid action reward"
line 255, reward = INVALID_ACTION_REWARD

I logged stuff. every action, even if valid, incurs a negative reward (or has that negative reward added)
If I set the pawn's value to 100, if it gets captured it's worth 90, as an example

All you need to do to fix this is remove IN, so that it's set to "reward = VALID_ACTION_REWARD"

also, please fix the queen promotion. It still isn't.

@Japple42
Copy link
Author

Japple42 commented Nov 4, 2021

Nevermind, this seems to have broken the invalid rewards, go freakin figure.

@Japple42
Copy link
Author

Japple42 commented Nov 4, 2021

So, there is currently no working version of invalid move punishments in the code, just, at all. something with line 366-368:

if action not in self.possible_actions:
reward = INVALID_ACTION_REWARD
return self.state, reward, self.done, self.info

is not correct, clearly. I am getting no invalid action reward to speak of, and my current attempts to get it have been unsuccessful. I'm going to try and figure out how to do this (because I kinda need to), and will leave an update when I get some version of this working

@Japple42 Japple42 changed the title VALID_ACTION_REWARD isn't configured correctly due to typo Valid Actions don't incur reward due to typo, invalid action reward isn't properly implemented Nov 4, 2021
@Japple42 Japple42 changed the title Valid Actions don't incur reward due to typo, invalid action reward isn't properly implemented Valid Actions don't incur reward due to typo, invalid action reward isn't properly implemented (ChessEnvV1) Nov 4, 2021
@Japple42
Copy link
Author

Japple42 commented Nov 4, 2021

I don't know why, but after repasting the code into visual studio and changing nothing but those two typos, it works. So, cool.

@Japple42 Japple42 changed the title Valid Actions don't incur reward due to typo, invalid action reward isn't properly implemented (ChessEnvV1) Valid Actions don't incur reward due to typo (ChessEnvV1) Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant