-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Valid Actions don't incur reward due to typo (ChessEnvV1) #22
Comments
Nevermind, this seems to have broken the invalid rewards, go freakin figure. |
So, there is currently no working version of invalid move punishments in the code, just, at all. something with line 366-368: if action not in self.possible_actions: is not correct, clearly. I am getting no invalid action reward to speak of, and my current attempts to get it have been unsuccessful. I'm going to try and figure out how to do this (because I kinda need to), and will leave an update when I get some version of this working |
I don't know why, but after repasting the code into visual studio and changing nothing but those two typos, it works. So, cool. |
line 254, there's a comment that says "valid action reward"
line 255, reward = INVALID_ACTION_REWARD
I logged stuff. every action, even if valid, incurs a negative reward (or has that negative reward added)
If I set the pawn's value to 100, if it gets captured it's worth 90, as an example
All you need to do to fix this is remove IN, so that it's set to "reward = VALID_ACTION_REWARD"
also, please fix the queen promotion. It still isn't.
The text was updated successfully, but these errors were encountered: