Enable python sdist (#156)

* Enable python sdist * re-enable only on tags
geoarrow · Aug 20, 2023 · 43373e7 · 43373e7
1 parent ccdd97a
commit 43373e7
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 40 deletions.
diff --git a/.github/workflows/python-core-wheels.yml b/.github/workflows/python-core-wheels.yml
@@ -148,52 +148,44 @@ jobs:
         with:
           path: python/geoarrow-rust/wheels/*.whl
 
-  # sdist build currently broken
-  # https://github.com/PyO3/maturin/issues/1083#issuecomment-1674085413
-
-  # build_sdist:
-  #   name: Build source distribution
-  #   runs-on: ubuntu-latest
-  #   defaults:
-  #     run:
-  #       working-directory: python/geoarrow-rust
-
-  #   steps:
-  #     - uses: actions/checkout@v3
-  #       with:
-  #         submodules: "recursive"
-
-  #     - uses: actions/setup-python@v2
-  #       name: Install Python
-  #       with:
-  #         python-version: "3.8"
-
-  #     - name: Install Rust
-  #       uses: dtolnay/rust-toolchain@stable
-
-  #     - run: |
-  #         pwd
-  #         ls ../../
-  #         cargo metadata
-
-  #     - name: Build sdist
-  #       run: |
-  #         pip install -U build
-  #         python -m build --sdist
-
-  #     # Have to set path from root
-  #     # https://github.com/actions/upload-artifact/issues/232#issuecomment-964235360
-  #     - uses: actions/upload-artifact@v2
-  #       with:
-  #         path: python/geoarrow-rust/dist/*.tar.gz
+  build_sdist:
+    name: Build source distribution
+    runs-on: ubuntu-latest
+    defaults:
+      run:
+        working-directory: python/geoarrow-rust
+
+    steps:
+      - uses: actions/checkout@v3
+        with:
+          submodules: "recursive"
+
+      - uses: actions/setup-python@v2
+        name: Install Python
+        with:
+          python-version: "3.8"
+
+      - name: Install Rust
+        uses: dtolnay/rust-toolchain@stable
+
+      - name: Build sdist
+        run: |
+          pip install -U build
+          python -m build --sdist
+
+      # Have to set path from root
+      # https://github.com/actions/upload-artifact/issues/232#issuecomment-964235360
+      - uses: actions/upload-artifact@v2
+        with:
+          path: python/geoarrow-rust/dist/*.tar.gz
 
   upload_pypi:
     needs:
       [
         build-wheel-manylinux2014,
         build-wheels-mac,
         build-wheel-windows,
-        # build_sdist,
+        build_sdist,
       ]
     runs-on: ubuntu-latest
     # Make sure we only run this on new tags/release

diff --git a/python/geoarrow-rust/pyproject.toml b/python/geoarrow-rust/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-requires = ["maturin>=1.2,<2.0"]
+requires = ["maturin>=1.2.1,<2.0"]
 build-backend = "maturin"
 
 [project]