Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SvelteKit breaking changes - build fails for versions >= next.208 #6

Closed
geoffrich opened this issue Oct 27, 2021 · 3 comments · Fixed by #17
Closed

Handle SvelteKit breaking changes - build fails for versions >= next.208 #6

geoffrich opened this issue Oct 27, 2021 · 3 comments · Fixed by #17

Comments

@geoffrich
Copy link
Owner

geoffrich commented Oct 27, 2021

sveltejs/kit#2580

  • Import app via $server-build alias instead of hard-coded relative path
  • Need to specify serverEntryPoint
  • Simply import @sveltejs/kit/install-fetch directly instead of more complicated shim

Reference that PR for README updates as well (no more custom esbuild config).

@geoffrich
Copy link
Owner Author

Update: looks like sveltejs/kit#2931 is the correct PR to reference, which also includes changes to generate functions per route instead of a single monolith.

@geoffrich
Copy link
Owner Author

Also some changes to integrate w/ the request object -- path/query have been replaced with URL. See sveltejs/kit#3133

@geoffrich geoffrich changed the title Handle SvelteKit breaking changes Handle SvelteKit breaking changes - build fails for versions >= next.208 Dec 31, 2021
@geoffrich geoffrich pinned this issue Dec 31, 2021
@geoffrich geoffrich unpinned this issue Jan 5, 2022
@geoffrich
Copy link
Owner Author

I made the updates to support v. next-208 and confirmed it works with the latest SvelteKit demo app. The linked PR did not include code-splitting API routes, since it seems like that's only implemented for the Netlify adapter and is marked as experimental. I'll look into implementing that feature when it's more stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant