Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move demo app into repo #69

Closed
geoffrich opened this issue Sep 27, 2022 · 3 comments · Fixed by #77
Closed

Move demo app into repo #69

geoffrich opened this issue Sep 27, 2022 · 3 comments · Fixed by #77

Comments

@geoffrich
Copy link
Owner

Move the demo app into this repo. This will allow us to more easily test adapter changes before releasing a new version. The demo should import the adapter directly instead of installing from npm.

This could also enable E2E tests on PRs.

We should be able to kick off a preview build for each PR (though maybe it should be configurable, since the preview notifications can be noisy.)

@FlippingBinary
Copy link
Contributor

I see there is a __layout.svelte in that demo app, which is from the old routing method. Would it be okay to build a new demo app with the latest version of SvelteKit instead of copying the existing one? There are no more planned breaking changes in SvelteKit since sveltejs/kit#6707, so it's stable enough now that it makes sense to rebuild.

@geoffrich
Copy link
Owner Author

Yeah, it would be cleanest to just regenerate the demo app with npm create svelte@latest instead of copying things over. The demo in that repo is pretty much just the default Kit demo with some adapter config anyway.

I had opened geoffrich/sveltekit-azure-swa-demo#8 to update to the latest Kit (as of a few weeks ago), but that PR can probably be closed if we're moving it into this repo anyway.

@geoffrich
Copy link
Owner Author

Re: auto-running the demo app deployment: possibly automatically deploy a preview for each autorelease PR (e.g. #76) and also allow manually doing a deployment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants