Sourcemaps aren't generated #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Let's leave the package-lock - the official adapters don't have one because they're part of a pnpm monorepo that has its own lockfile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #73 by setting
sourcemap: 'linked'. I couldn't find any mention of when thelinkedoption was added to esbuild, but the previous version of esbuild was not compatible with it. For that reason, I updated to the same version used by the official adapters.Meanwhile, I noticed the supported adapters do not commit their
package-lock.jsonfile. Perhaps it would be better to deletepackage-lock.jsonand add it to.gitignore. I think it may interfere with npm's deduplication, but I haven't tested that. The file definitely isn't required.