-
Notifications
You must be signed in to change notification settings - Fork 358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are there any plans on including zip code in the result? #190
Comments
If it's in the MaxMind data, then it should be present. We haven't removed it. |
It's not in the result. I actually managed to get it in my fork already- kilobyte2007@f8278e7 Would a pull-request make sense? |
yes |
There's apparently an issue committing fresh .dat files as they are more than 100MB (~103MB) and that's more than GitHub allows. Any ideas? |
I don't think we can add new dat files to the repo due to the Maxmind
licence changes. The dat files have to be downloaded using the update
script after installation. We can continue to include the old dat files.
|
I see, but the issue is that the structure of the .dat file changed so now if you will just install the node-geoip module (with my changes) without calling updatedb - it will throw an error. |
So no solution on how to get the zip or postal code back in the response? I recently updated the package and run the update db script and it is gone. |
I found the solution here kilobyte2007@f8278e7 and remember to run the update db script after the changes are made. |
hi @kilobyte2007 |
I did not add a PR because in my solution the .dat file was bigger and it was impossible to commit it. |
I have created ip-location-api which has similar in-memory database system with # Update database
npm run updatedb ILA_FIELDS=country,region1,city,metro,eu,timezone,latitude,area,postcode
# application run
node your_application.js ILA_FIELDS=country,region1,city,metro,eu,timezone,latitude,area,postcode |
I've noticed that in previous versions the result had the zipCode property. What's the reason for getting rid of it and are there plans on bringing it back?
The text was updated successfully, but these errors were encountered: