Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calculate Wheel Size from BB Drop and BB height #16

Open
jdtoy opened this issue Dec 8, 2017 · 2 comments
Open

Calculate Wheel Size from BB Drop and BB height #16

jdtoy opened this issue Dec 8, 2017 · 2 comments

Comments

@jdtoy
Copy link
Member

jdtoy commented Dec 8, 2017

When both the bottom bracket (BB) height and the bottom bracket drop are specified as inputs, calculate the wheel size (outer radius). This wheel size is likely to be more correct, diagrammatically, than currently methods.

Reference on wiki: Points on a Bike

@Bob-GG
Copy link

Bob-GG commented Dec 9, 2017

BB Drop is often provided in geo tables with a + or - sign. On the great majority of bikes it's "downward", i.e. BB lies below a line between the front and rear axles.

As per a discussion jdtoy and I had, we propose:

  • If unsigned, assume downward
  • If -ve, assume downward
  • If +ve, assume upward

jdtoy added a commit that referenced this issue Dec 20, 2017
Correct the +/- parsing of Bottom Bracket Drop, as described in #16
@jdtoy
Copy link
Member Author

jdtoy commented Dec 20, 2017

I've implemented a fix for the +/- parsing issue. Using this corrected value to calculate the Outer wheel diameter is still to do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants