Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlalchemy tests fail due to non existing management keyword argument #86

Closed
ricardogsilva opened this issue Dec 21, 2023 · 2 comments · Fixed by #87
Closed

sqlalchemy tests fail due to non existing management keyword argument #86

ricardogsilva opened this issue Dec 21, 2023 · 2 comments · Fixed by #87

Comments

@ricardogsilva
Copy link
Member

geoalchemy removed the management argument from the intialization of a geoalchemy2.types._GISType earlier this year:

geoalchemy/geoalchemy2#415

As a result of this change, subsequent geoalchemy releases are not compatible with pygeofilter's sqlalchemy tests, which are still using the management keyword argument:

class Record(Base):
__tablename__ = "record"
identifier = Column(String, primary_key=True)
geometry = Column(
Geometry(
geometry_type="MULTIPOLYGON",
srid=4326,
spatial_index=False,
management=True,
)
)

This means the tests are currently failing.

Possible solutions:

  1. Follow suite with geoalchemy2 and simply remove the management argument
  2. Pin geoalchemy2 to a known version

I guess the first option is better, since the fix is really small - I'll prepare a PR with the change

@tomkralidis
Copy link
Member

@ricardogsilva what is the version of geoalchemy which introduces this change?

@ricardogsilva
Copy link
Member Author

@tomkralidis

I believe it was version 0.14.0, which got released back in the beginning of July 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants