mfapp - sorting contexts alphabetically #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This feature was asked by several customers, in datadir mode, since the contexts are not set in the GEOR_custom.js file anymore, we need to set a convenient way to sort them. an alphabetical sort (case-insensitive) seems to be a good choice.
|
LGTM, please merge |
|
I'd like to wait for feedback from PIGMA before, we might need to sort by title alphabetically instead of filenames. Not sure of the expected behaviour. |
|
... then ping @pigma ;-) |
Since the context titles appears in the viewer window, this seems logic, indeed. |
|
Maybe this should rather be merged into master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was asked by several customers, in datadir mode, since the contexts are not set in the GEOR_custom.js file anymore, we need to set a convenient way to sort them.
an alphabetical sort (case-insensitive) seems to be a good choice.
Tests: u-test added, not tested at runtime yet (planned to do a live-testing on pigma-dev)