mapfishapp - chooses the wrong proxy

[fvanderbiest]

There is a problem with this code in mapfishapp:
https://github.com/georchestra/georchestra/blob/master/mapfishapp/src/main/filtered-resources/WEB-INF/jsp/index.jsp#L133

Evaluating request.getContextPath() against "/mapfishapp" or "/mapfishapp-private" is not the correct way to check whether we're running under jetty or tomcat (the sec-proxy can live in a different tomcat).

The goal of this check is to choose the proxy for cross domain XHRs: either the security proxy when running under tomcat, or the local ogc proxy when running with jetty (dev mode).

[fvanderbiest]

One solution would be that the security proxy always adds a custom header to the forwarded request, eg: sec-proxy = true.

Mapfishapp would look for this header in the incoming request.
If present, it would use the sec-proxy.
If not, the local proxy.