Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to the geo-types crate #8

Merged
merged 2 commits into from
May 12, 2018
Merged

Migrate to the geo-types crate #8

merged 2 commits into from
May 12, 2018

Conversation

lnicola
Copy link
Member

@lnicola lnicola commented May 11, 2018

Fixes #7.

@lnicola
Copy link
Member Author

lnicola commented May 11, 2018

Heads-up: test_conversion_error no longer works with proj 5.0.1, as the transform returns a point at infinity instead of an error.

@urschrei
Copy link
Member

Oof. I've asked why.

@urschrei urschrei mentioned this pull request May 12, 2018
Merged
bors bot added a commit that referenced this pull request May 12, 2018
@bors @urschrei
Merge #10
94d44d9 
10: Create valid error r=urschrei a=urschrei

See discussion at #8 
Error taken from
https://github.com/OSGeo/proj.4/blob/master/test/gie/4D-API_cs2cs-style.gie#L194

5.0.1 now accepts certain nonsensical input, but returns inf, inf
instead of an error. See: OSGeo/PROJ#992 (comment)

Co-authored-by: Stephan Hügel <urschrei@gmail.com>
@urschrei
Copy link
Member

bors r=urschrei

bors bot added a commit that referenced this pull request May 12, 2018
@bors @lnicola
Merge #8
8011200 
8: Migrate to the geo-types crate r=urschrei a=lnicola

Fixes #7.

Co-authored-by: Laurentiu Nicola <lnicola@dend.ro>
@bors
Copy link
Contributor

bors bot commented May 12, 2018

Build succeeded

@bors bors bot merged commit 406b832 into georust:master May 12, 2018
@urschrei
Copy link
Member

Now on crates.io as 0.5.0. Thanks!

@lnicola lnicola deleted the geo-types branch May 12, 2018 12:09
urschrei added a commit to urschrei/rust-proj that referenced this pull request Sep 28, 2020
@bors @urschrei
Merge georust#8
6f1dd1a 
8: Update to PROJ 7.0.0 r=urschrei a=urschrei



Co-authored-by: Stephan Hügel <shugel@tcd.ie>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lnicola @urschrei