Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SUBMODULE UPDATES] Implementation of TOMAS in GCHP #220

Closed
3 tasks
BettyCroft opened this issue May 24, 2022 · 5 comments
Closed
3 tasks

[SUBMODULE UPDATES] Implementation of TOMAS in GCHP #220

BettyCroft opened this issue May 24, 2022 · 5 comments
Assignees
@Jourdan-He
Labels
category: Feature Request New feature or request category: Submodule Update Instructions never stale Never label this issue as stale topic: Carbon Simulation Specific to GCHP carbon simulation

Comments

@BettyCroft
Copy link
Contributor

BettyCroft commented May 24, 2022 •
edited by LiamBindle
Loading

Brief Description

Code updates for implementation of TOMAS in GCHP

Related Issues

Code updates 1) enabling TOMAS to work in GCHP, 2) removing TOMAS' dependency on bpch diagnostics, 3) adding a TOMAS diagnostic collection and 4) adding blowing snow sea salt to TOMAS. The latter 3 items would also be suitable for GC-Classic.

Submodule Pull Requests
@BettyCroft BettyCroft changed the title Implementation of TOMAS in GCHP Superproject instructions for submodule updates: Implementation of TOMAS in GCHP May 24, 2022
@lizziel lizziel added this to the 14.1.0 milestone Jun 24, 2022
@lizziel
Copy link
Contributor

lizziel commented Jun 24, 2022

Thanks @BettyCroft! This update will go into 14.1.0.

@lizziel lizziel added category: Feature Request New feature or request topic: Carbon Simulation Specific to GCHP carbon simulation labels Jun 24, 2022
@LiamBindle LiamBindle added the never stale Never label this issue as stale label Jul 26, 2022
@lizziel lizziel assigned Jourdan-He and unassigned LiamBindle Aug 30, 2022
@Jourdan-He
Copy link
Contributor

Hi @BettyCroft , all your updates have been merged into a feature/TOMAS branch waiting to be tested.

@Jourdan-He
Copy link
Contributor

I have test run the updates, and it's completed successfully. Pull requests for merging into dev have been created.

@BettyCroft
Copy link
Contributor Author

Great news - thanks!

@lizziel lizziel changed the title Superproject instructions for submodule updates: Implementation of TOMAS in GCHP [INSTRUCTIONS FOR SUPERPROJECT] Implementation of TOMAS in GCHP Nov 4, 2022
@lizziel lizziel changed the title [INSTRUCTIONS FOR SUPERPROJECT] Implementation of TOMAS in GCHP [SUBMODULE UPDATES] Implementation of TOMAS in GCHP Nov 7, 2022
@msulprizio
Copy link
Contributor

These instructions are now superseded by PR #252.

@msulprizio msulprizio removed this from the 14.1.0 milestone Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jourdan-He Jourdan-He

Labels
category: Feature Request New feature or request category: Submodule Update Instructions never stale Never label this issue as stale topic: Carbon Simulation Specific to GCHP carbon simulation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lizziel @msulprizio @LiamBindle @Jourdan-He @BettyCroft