Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetCapabilites parsing error for inspire_vs:ExtendedCapabilities #6489

Closed
1 task done
Tracked by #4675
MV88 opened this issue Jan 28, 2021 · 5 comments · Fixed by #10459
Closed
1 task done
Tracked by #4675

GetCapabilites parsing error for inspire_vs:ExtendedCapabilities #6489

MV88 opened this issue Jan 28, 2021 · 5 comments · Fixed by #10459

Comments

@MV88
Copy link
Contributor

MV88 commented Jan 28, 2021

Description

Mapstore currently fails to parse the GetCapabilities result that contains inspire_vs:ExtendedCapabilities for retrieving styles.
it fails here and it goes then in the catch here

I also noticed a variety of ways to retrieve & parse getCapabilities we should unify
https://github.com/geosolutions-it/MapStore2/blob/master/web/client/actions/layerCapabilities.js#L55
https://github.com/geosolutions-it/MapStore2/blob/master/web/client/api/WMS.js#L113
https://github.com/geosolutions-it/MapStore2/blob/master/web/client/api/WMS.js#L169
https://github.com/geosolutions-it/MapStore2/blob/master/web/client/observables/wms.js#L42

How to reproduce

  • open map with id 451 map
  • open TOC
  • select layer temperatura
  • open layer settings
  • check debugging the notified points

Expected Result

to see the styles for that layer

Current Result

there is this error when parsing with jsonix

"Element [{http://inspire.ec.europa.eu/schemas/inspire_vs/1.0}inspire_vs:ExtendedCapabilities] 
could not be unmarshalled as is not known in this context and the property does not allow DOM content."

so the styles list is empty

  • Not browser related
Browser info (use this site: https://www.whatsmybrowser.org/ for non expert users)
Browser Affected Version
Internet Explorer
Edge
Chrome
Firefox
Safari

Other useful information

@tdipisa
Copy link
Member

tdipisa commented Mar 4, 2021

@MV88 I remember that this issue is related to a problem with the library MS is using to parse the GetCapabilities output. Are there more details that can be included in the description to help with the estimate?

@offtherailz can you please confirm the estimate and provide more hints for the implementation part as a result of your investigation?

@MV88
Copy link
Contributor Author

MV88 commented Mar 4, 2021

the issue description is already well detailed.
The estimate is big because the only solution I can think of is:
replacing ogc schemas with xml2js

this would have also other benefits in terms of performance (reduced bundle size)

@landryb
Copy link
Collaborator

landryb commented Feb 11, 2022

my understanding of this issue is that the ogc-schemas npm module lacks proper support for inspire schemas...

@landryb
Copy link
Collaborator

landryb commented Feb 15, 2022

@MV88 you might want to try what i did in landryb/MapStore2@35f31b2 to add support for inspire schemas

@tdipisa
Copy link
Member

tdipisa commented Aug 28, 2024

@ElenaGallo still waiting for your functional tests here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment