Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RasterSource Transformation ADT #198

Open
echeipesh opened this issue Jun 27, 2019 · 0 comments
Open

RasterSource Transformation ADT #198

echeipesh opened this issue Jun 27, 2019 · 0 comments
Labels
question Further information is requested

Comments

@echeipesh
Copy link
Collaborator

Ref: #138

This actually leads me to another point which is RasterSource currently mixes (at least) two concerns that may deserve to be separated:

  • How to read (sub-)rasters (efficiently)
  • How to do that while efficiently transforming the data into the desired form without large data copies

(Do you agree? Have I missed any?)

The first is obvious and core to the abstraction. The second is technically a performance optimization, but a required one. My gut says this responsibility could be separately abstracted, using something akin to an AST (maybe even a linear one), providing easier testing, reusability, and less implementation bleeding.
@metasim

There was also a suggestion from @jbouffard to add some kind of inspect-able way to query that RasterSource transformations as part of the CellType conversion PR.

I think this is worth a discussion to determine if the benefits are worth the refactor.

Outcome of this issue is either a work task issue to implement something along the lines of suggestion or explicit decision not to do it.

@echeipesh echeipesh added the question Further information is requested label Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant