Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ProxyResolver hides the "truncated" flag #29

Open
JirkaV opened this issue Jan 31, 2023 · 0 comments
Open

ProxyResolver hides the "truncated" flag #29

JirkaV opened this issue Jan 31, 2023 · 0 comments
Labels

Comments

@JirkaV
Copy link

JirkaV commented Jan 31, 2023

I was chasing down an issue where some DNS responses were empty when using async_dns. This turned out to be a problem with too large responses for UDP and I realized I need to switch to TCP for these queries. This is totally fine and should be my responsibility, the problem is that the .tc attribute signalling that response is truncated and new query needs to be sent over TCP is lost.

It'd seem that the problem is in the _query method of ProxyResolver which does nothing to propagate the .tc flag from the actual DNS server response to the final response.

I'd send a pull request but don't feel like I know DNS well enough to be confident about my own fix :)

Also - thank you for providing such useful library!

@gera2ld gera2ld added the bug label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants