Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate improvements to the woke update cycle within vs-code-extension #10

Open
mkcomer opened this issue Jul 19, 2021 · 3 comments

Comments

@mkcomer
Copy link

mkcomer commented Jul 19, 2021

No description provided.

@caitlinelfring
Copy link
Member

The vs-code woke extension doesn't manage the installation of woke, you need to install it yourself and it will use whatever it can find in your $PATH, or what you define in the extension setting woke.executablePath. Try upgrading your version of woke: https://github.com/get-woke/woke#installation

@caitlinelfring
Copy link
Member

That said... the only reason for this is I don't have any experience with building vscode extensions, so I would welcome any improvements to the woke update cycle!

@mkcomer mkcomer changed the title Upgrade vscode-woke to latest version of woke binary 0.9.3 Update woke binary "BEST_TOOL_VERSION" in vscode-woke to woke's latest release Oct 19, 2021
@mkcomer mkcomer changed the title Update woke binary "BEST_TOOL_VERSION" in vscode-woke to woke's latest release Investigate improvements to the woke update cycle within vs-code-extension Oct 19, 2021
@mkcomer
Copy link
Author

mkcomer commented Oct 19, 2021

Resurfacing this issue.

Is your feature request related to a problem? Please describe.
There is a disableVersionCheck on the vs-code woke extension that checks that your woke is up to date with the latest version. However, when I ran the VS Code extension with woke 0.9.0 (woke's latest is on version 0.15.0), I was not prompted to update my woke binary.

While I recognize that the vs-code woke extension doesn't manage the installation of woke, this could create compatibility issues, as well as confusion for why certain feature enhancements are not functional in the extension (if you are running your extension off an old binary woke).

Describe the solution you'd like

After investigating the disableVersionCheck, there is logic to compare the local binary vs. the BEST_TOOL_VERSION (the latest version of woke binary you should be on). If local binary version < BEST_TOOL_VERSION --> prompt user to update woke binary. The BEST_TOOL_VERSION is hardcoded to 0.2.0. This explains why when I was running the extension on 0.9.0 (and woke's latest is on 0.15.0), I was not prompted to update my binary.

Describe alternatives you've considered

  1. Is this desired functionality? That the vs-code woke extension only cares about running off of woke binary 0.2.0 or later? If so, does this create compatibility issues/confusion as to why latest features are not working in your vs code?
  2. Do we want to update the hardcoded value for BEST_TOOL_VERSION to 0.15.0?
  3. Is there interest in investigating ways to automate this process: If woke releases a new version --> update "BEST_TOOL_VERSION" in vs-code woke extension?

Additional context
Curious your thoughts on alternative solutions/next steps here. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants