Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that we can re-broadcast transactions #1139

Closed
bonomat opened this issue Aug 22, 2023 · 3 comments · Fixed by #1168
Closed

Ensure that we can re-broadcast transactions #1139

bonomat opened this issue Aug 22, 2023 · 3 comments · Fixed by #1168
Assignees
Labels

Comments

@bonomat
Copy link
Contributor

bonomat commented Aug 22, 2023

If a transaction was not included yet in the mempool, the app/coordinator should try to rebroadcast the transaction, e.g. on restart.

Alternatively, we could store all broadcasted transactions in the DB and do it manually when needed.

@bonomat
Copy link
Contributor Author

bonomat commented Aug 22, 2023

Critical because if we do not do this yet we might lose the posibility to broadcast old transactions. Our logs get pruned after 30 days.

@holzeis
Copy link
Contributor

holzeis commented Aug 30, 2023

@bonomat is this really fixed? your change only stores the raw transaction but does not try to re-broadcast them, or does it?

@bonomat
Copy link
Contributor Author

bonomat commented Aug 30, 2023

Correct. I descoped this part and only focused on storing it so that we can manually re-broadcast when needed.

@klochowicz klochowicz changed the title Ensure that broadcasted transactions are re-broadcasted Ensure that we can re-broadcast transactions Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants