Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove parsing lightning invocies #1903

Merged
merged 1 commit into from
Jan 26, 2024

Conversation

bonomat
Copy link
Contributor

@bonomat bonomat commented Jan 26, 2024

Resolves #1796

If you scan a LN invoice you get a beautiful error dialog

image

Copy link
Contributor

@holzeis holzeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
## [Unreleased]

- Chore: Enforce minimum quantity to 500 on dlc channel open
- Chore(app): Remove paying lightning invoices
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- Chore(app): Remove paying lightning invoices
- Chore(app): Disable paying lightning invoices

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The screen has been removed, so not just disabled :)

@bonomat bonomat force-pushed the chore/remove-lighting-from-app branch from 89c1c35 to 06005a2 Compare January 26, 2024 08:37
@bonomat bonomat enabled auto-merge January 26, 2024 08:37
@bonomat bonomat added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@bonomat bonomat added this pull request to the merge queue Jan 26, 2024
Merged via the queue into main with commit bdd7d30 Jan 26, 2024
9 checks passed
@bonomat bonomat deleted the chore/remove-lighting-from-app branch January 26, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lightning invoice feature from app
3 participants