Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add emergency kit screen to set pending orders to failed #1948

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

holzeis
Copy link
Contributor

@holzeis holzeis commented Feb 2, 2024

Introduces an emergency kit section to the settings to cleanup pending orders. I think this pattern might be useful in the future to selectively fix broken states on the app site.

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2024-02-02.at.12.44.37.mp4

@holzeis holzeis requested review from bonomat and luckysori February 2, 2024 11:49
@holzeis holzeis self-assigned this Feb 2, 2024
@holzeis holzeis linked an issue Feb 2, 2024 that may be closed by this pull request
Copy link
Contributor

@bonomat bonomat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the side effect of setting Filling orders to failed`? If we get a match later on, we would simply fail right?

mobile/native/src/db/models.rs Show resolved Hide resolved
@holzeis
Copy link
Contributor Author

holzeis commented Feb 3, 2024

What's the side effect of setting Filling orders to failed`? If we get a match later on, we would simply fail right?

Can't predict all side effects, but in the case if we would have a regular order which gets executed. We would get an error when trying to set the order to Filled as the Filling order was not found. That would also prevent the position from getting created on the app side, but the dlc channel would be set up.

@holzeis holzeis force-pushed the feat/add-emergency-kit-to-settings-page branch 2 times, most recently from 9f118c4 to bc75665 Compare February 3, 2024 10:15
@holzeis holzeis enabled auto-merge February 3, 2024 10:15
@holzeis holzeis force-pushed the feat/add-emergency-kit-to-settings-page branch from bc75665 to 45b93c1 Compare February 3, 2024 12:15
@holzeis holzeis added this pull request to the merge queue Feb 3, 2024
Merged via the queue into main with commit d527f35 Feb 3, 2024
9 checks passed
@holzeis holzeis deleted the feat/add-emergency-kit-to-settings-page branch February 3, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add emergency kit to settings page to set filling orders to failed
2 participants