revert: Serialize channel message #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes ``` [ERROR] TIME: 2024-02-03T15:39:38.448459Z r: Failed to process on connect event. unknown variant `temporaryChannelId`, expected one of `Offer`, `Accept`, `Sign`, `SettleOffer`, `SettleAccept`, `SettleConfirm`, `SettleFinalize`, `RenewOffer`, `RenewAccept`, `RenewConfirm`, `RenewFinalize`, `RenewRevoke`, `CollaborativeCloseOffer`, `Reject` at line 1 column 21 peer: 02dd6abec97f9a748bf76ad502b004ce05d1b2d1f43a9e76bd7d85e767ffb022c9 ```
luckysori
approved these changes
Feb 5, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I opted to revert this change as it was a mere refactoring and it's not worth to break serializing and deserializing
last_outbound_dlc_messages.messagefor it. Even if it would have had only a minor downside (being that the last message could not be resend and producing the below error).fixes