Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Bitcoin Jungle wallet instructions are incorrect #3017

Open
1 task done
leesalminen opened this issue Feb 7, 2024 · 2 comments
Open
1 task done

[BUG] Bitcoin Jungle wallet instructions are incorrect #3017

leesalminen opened this issue Feb 7, 2024 · 2 comments

Comments

@leesalminen
Copy link
Contributor

Is there an existing issue for this?

  • I have searched the existing issues

Describe the bug

When attempting to connect Bitcoin Jungle wallet to Alby, it presents these instructions:

Screenshot 2024-02-07 at 7 43 02 AM

These instructions do not work for Bitcoin Jungle wallet as we do not display the access token on the developer settings screen. We never have. I think this was a copy/paste from the upstream project, Blink.

Users must obtain their token by receiving an SMS/WhatsApp message with a 6 digit code and providing that code in exchange for a token.

Screenshots [optional]

No response

Steps To Reproduce

  1. Visit Alby Extension
  2. Click Add New Account
  3. Under Bring Your Own Wallet, click Connect
  4. Click Bitcoin Jungle Wallet
  5. You are prompted to locate an access code which cannot be found

Expected behavior

After step 4, the user should be prompted to enter their phone number, including country code, and decide whether they want the message over SMS or WhatsApp. They should then enter the 6 digit code to obtain a token.

Alby information

  • 3.6.0
  • Firefox
  • Installed from store

Device information

No response

Additional context

No response

Are you working on this?

None

@reneaaron
Copy link
Contributor

@openoms Do we need to separate the connectors for Galoy / Bitcoin Jungle here then?

@leesalminen Are there any plans to upgrade to this new flow / auth tokens in future?

@openoms
Copy link
Contributor

openoms commented Feb 7, 2024

The state of the galoy connector for Bitcoin Jungle was preserved as it was previously, so the instructions might have been never right. In the recent changes I have been focusing on not breaking the existing connections using the access token.

I think at this point it would make sense to diverge the two connectors as the Blink API has different authentication method, updated calls and possible Stablesats integration: #2730

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants