Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix/aws iam role paramater changed #11

Merged
merged 4 commits into from
Aug 1, 2018
Merged

Bug fix/aws iam role paramater changed #11

merged 4 commits into from
Aug 1, 2018

Conversation

smalltown
Copy link
Contributor

@smalltown smalltown commented Jul 31, 2018 •
edited
Loading

  1. Due to terraform AWS plguin changed, hence changing variable role_arn to role_name
  2. Link IAM policy and IAM role only when role_name is empty string

@smalltown smalltown requested a review from alanchchen July 31, 2018 11:04
@smalltown smalltown merged commit 54b2e54 into master Aug 1, 2018
@smalltown smalltown deleted the bug_fix/aws_iam_role_paramater_changed branch August 1, 2018 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanchchen alanchchen alanchchen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smalltown @alanchchen